rdblue commented on a change in pull request #1465:
URL: https://github.com/apache/iceberg/pull/1465#discussion_r491128772
##########
File path:
core/src/main/java/org/apache/iceberg/hadoop/HadoopTableOperations.java
##########
@@ -289,19 +311,24 @@ int readVersionHint() {
return Integer.parseInt(in.readLine().replace("\n", ""));
} catch (Exception e) {
- LOG.warn("Error reading version hint file {}", versionHintFile, e);
+ LOG.debug("Error reading version hint file {}", versionHintFile, e);
Review comment:
> Could someone please point me a place (code lines) where and how
Iceberg configurations are handled, so I can use them correctly?
I don't think we need this option since Jacques replied that he agrees it
should not be an exception.
For configuration, we prefer to use table properties for most configuration,
which are defined in the `TableProperties` class. For other cases, we use the
configuration that makes the most sense. Here, I would use the Hadoop
configuration because the table implementation is for Hadoop and HDFS.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
