rdblue commented on pull request #1469: URL: https://github.com/apache/iceberg/pull/1469#issuecomment-695049208
> do we want to make the validation mandatory? Probably not. There is more than one way to guarantee that a delete is safe and I don't want to force implementations to work around checks imposed by the commit operations. For example, you could have a delete application that applies deletes, commits optimistically, and the goes back to check whether any files were rewritten and delete from those files. That would delete rows more quickly and make incremental progress, at the cost of ensuring all rows were deleted at the same time. Similarly, I could "lock" a table with an external service and perform deletes in that window to avoid contention. I think the motivation for the suggestion is good -- how do we prevent API callers from making mistakes -- but we do have to trust that they know what they are doing most of the time. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
