danielcweeks commented on code in PR #12718:
URL: https://github.com/apache/iceberg/pull/12718#discussion_r2031534136
##########
aws/src/integration/java/org/apache/iceberg/aws/glue/TestGlueCatalogTable.java:
##########
@@ -343,28 +342,32 @@ public void testRenameTableFailsToCreateNewTable() {
public void testRenameTableFailsToDeleteOldTable() {
String namespace = createNamespace();
String tableName = createTable(namespace);
- // delete the old table metadata, so that drop old table will fail
+
+ // Simulate table was dropped during rename, where new table already
created and need to delete
+ // old table
+ GlueCatalog glueCatalogSpy = Mockito.spy(glueCatalog);
Review Comment:
I'm a little concerned that we're creating the scenario that we're testing
here. Since we're creating the exception and testing for it, it's not clear to
me that we're simulating real behavior. Would it be possible to use the spy to
drop the table after the new table is created so that the real exception occurs
from the client?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
