nastra commented on code in PR #12768:
URL: https://github.com/apache/iceberg/pull/12768#discussion_r2041562055
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -2636,7 +2636,11 @@ public void testTableExistsViaHEADRequest() {
any());
Mockito.verify(adapter)
.execute(
- reqMatcher(HTTPMethod.HEAD, "v1/namespaces/newdb/tables/table",
Map.of(), Map.of()),
+ reqMatcher(
+ HTTPMethod.HEAD,
+ "v1/namespaces/" + TABLE.namespace() + "/tables/" +
TABLE.name(),
Review Comment:
but if we're going to fix this here, then we should fix this in the entire
test class. You should also be able to replace this with
`RESOURCE_PATHS.table(TABLE)`
##########
core/src/test/java/org/apache/iceberg/rest/TestRESTCatalog.java:
##########
@@ -2636,7 +2636,11 @@ public void testTableExistsViaHEADRequest() {
any());
Mockito.verify(adapter)
.execute(
- reqMatcher(HTTPMethod.HEAD, "v1/namespaces/newdb/tables/table",
Map.of(), Map.of()),
+ reqMatcher(
+ HTTPMethod.HEAD,
+ "v1/namespaces/" + TABLE.namespace() + "/tables/" +
TABLE.name(),
Review Comment:
you should be able to replace this with
`ResourcePaths.forCatalogProperties(Map.of()).table(TABLE)`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
