Xuanwo commented on PR #760: URL: https://github.com/apache/iceberg-rust/pull/760#issuecomment-2801170909
> I haven't done a benchmark on iceberg-rust yet. In RisingWave, we used to have a similar PR [risingwavelabs/risingwave#4182](https://github.com/risingwavelabs/risingwave/pull/4182). In RisingWave's LSM SST iterator, we used to have to create a `BoxedFuture` for every row in SST due to the previous use of `async_trait`. After using static-typed future, we've observed at most 20% improvement in the benchmark. Thank you for sharing this. However, the difference between having loops inside a `Box<dyn Iterator>` and `impl Iterator` can be quite significant compared to the difference between a `Box<dyn Future>` and `impl Future`, especially when I/O is involved. I suggest having a simple benchmark for us to evaluate in these cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
