rdblue commented on a change in pull request #1473: URL: https://github.com/apache/iceberg/pull/1473#discussion_r492354361
########## File path: spark3-extensions/src/main/scala/org/apache/spark/sql/catalyst/procedures/procedure.scala ########## @@ -0,0 +1,43 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.spark.sql.catalyst.procedures + +import org.apache.spark.sql.execution.command.RunnableCommand +import org.apache.spark.sql.types.DataType + +trait Procedure { + def name: String + def parameters: Seq[Parameter] + def createRunnableCommand(args: Array[Any]): RunnableCommand Review comment: Yes, but the problem with `RunnableCommand` is that it is a logical plan. Executing it with `ExecutedCommandExec` runs a logical plan in your physical plan. That's okay if it just needs to do one simple thing. But if it needs to do something that _should_ be done by a query it is a bad practice. For all of the v2 plans, we opted to use real physical plans to avoid problems. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
