Fokko commented on code in PR #1920:
URL: https://github.com/apache/iceberg-python/pull/1920#discussion_r2047692676
##########
pyiceberg/catalog/glue.py:
##########
@@ -303,11 +303,17 @@ def add_glue_catalog_id(params: Dict[str, str], **kwargs:
Any) -> None:
class GlueCatalog(MetastoreCatalog):
- def __init__(self, name: str, **properties: Any):
+ glue: GlueClient
+
+ def __init__(self, name: str, client: GlueClient | None = None,
**properties: Any):
super().__init__(name, **properties)
retry_mode_prop_value = get_first_property_value(properties,
GLUE_RETRY_MODE)
+ if client:
+ self.glue = client
+ return
Review Comment:
Nit! Can we turn this into an `if ... else`? I think the `return` is harder
to read.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
