wgtmac commented on code in PR #75:
URL: https://github.com/apache/iceberg-cpp/pull/75#discussion_r2048051700
##########
src/iceberg/statistics_file.cc:
##########
@@ -23,29 +23,26 @@
namespace iceberg {
-bool BlobMetadata::Equals(const BlobMetadata& other) const {
- return type == other.type && source_snapshot_id == other.source_snapshot_id
&&
- source_snapshot_sequence_number ==
other.source_snapshot_sequence_number &&
- fields == other.fields && properties == other.properties;
-}
-
-std::string BlobMetadata::ToString() const {
+std::string ToString(const BlobMetadata& blob_metadata) {
std::string repr = "BlobMetadata[";
std::format_to(std::back_inserter(repr),
-
"type='{}',sourceSnapshotId={},sourceSnapshotSequenceNumber={},", type,
- source_snapshot_id, source_snapshot_sequence_number);
+
"type='{}',sourceSnapshotId={},sourceSnapshotSequenceNumber={},",
+ blob_metadata.type, blob_metadata.source_snapshot_id,
+ blob_metadata.source_snapshot_sequence_number);
std::format_to(std::back_inserter(repr), "fields=[");
- for (auto iter = fields.cbegin(); iter != fields.cend(); ++iter) {
- if (iter != fields.cbegin()) {
+ for (auto iter = blob_metadata.fields.cbegin(); iter !=
blob_metadata.fields.cend();
Review Comment:
I'll refactor the formatter code later so let's keep it simple here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
