aokolnychyi commented on a change in pull request #1427:
URL: https://github.com/apache/iceberg/pull/1427#discussion_r493013236
##########
File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java
##########
@@ -101,6 +101,8 @@ int lastAssignedFieldId() {
}
/**
+ * Returns the {@link PartitionField field} that partitions the given source
field
Review comment:
nit: `.` at the end?
##########
File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java
##########
@@ -101,6 +101,8 @@ int lastAssignedFieldId() {
}
/**
+ * Returns the {@link PartitionField field} that partitions the given source
field
Review comment:
Actually, there are quite a few of them. Nevermind.
##########
File path: api/src/main/java/org/apache/iceberg/PartitionSpec.java
##########
@@ -101,6 +101,8 @@ int lastAssignedFieldId() {
}
/**
+ * Returns the {@link PartitionField field} that partitions the given source
field
Review comment:
Actually, there are quite a few of them. Never mind.
##########
File path: spark/src/main/java/org/apache/iceberg/spark/SparkExceptionUtil.java
##########
@@ -39,7 +40,9 @@ private SparkExceptionUtil() {
* @param args format specifiers
* @return unchecked exception.
*/
- public static RuntimeException toUncheckedException(Throwable cause, String
message, Object... args) {
+ @FormatMethod
+ public static RuntimeException toUncheckedException(final Throwable cause,
final String message,
Review comment:
Can we format it like this?
```
public static RuntimeException toUncheckedException(final Throwable cause,
final String message,
final Object... args)
```
or
```
public static RuntimeException toUncheckedException(
final Throwable cause, final String message, final Object... args)
```
Can we also add a comment clarifying why we need final args? We don't
usually do that in the rest of the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
