rodmeneses commented on code in PR #12839:
URL: https://github.com/apache/iceberg/pull/12839#discussion_r2050952065
##########
flink/v1.20/flink/src/test/java/org/apache/iceberg/flink/source/enumerator/TestContinuousSplitPlannerImpl.java:
##########
@@ -210,6 +210,43 @@ public void
testIncrementalFromLatestSnapshotWithEmptyTable() throws Exception {
}
}
+ @Test
+ public void testIncrementalFromLatestSnapshotExclusiveWithEmptyTable()
throws Exception {
Review Comment:
nit: Looks like this test is identical to
testIncrementalFromLatestSnapshotWithEmptyTable, except for the
StreamingStartingStrategy. If it is, we can refactor it with @TestTemplate to
avoid maintaining the 2.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]