rdsr commented on a change in pull request #1478:
URL: https://github.com/apache/iceberg/pull/1478#discussion_r493699459
##########
File path: build.gradle
##########
@@ -458,14 +471,29 @@ project(':iceberg-mr') {
testCompile("org.apache.calcite:calcite-core")
testCompile("com.esotericsoftware:kryo-shaded:4.0.2")
testCompile("com.fasterxml.jackson.core:jackson-annotations:2.6.5")
- testCompile("com.klarna:hiverunner:5.2.1") {
+ testCompile("com.klarna:hiverunner") {
exclude group: 'javax.jms', module: 'jms'
exclude group: 'org.apache.hive', module: 'hive-exec'
exclude group: 'org.codehaus.jettison', module: 'jettison'
exclude group: 'org.apache.calcite.avatica'
}
}
}
+if (!gradle.ext.hive3Enabled) {
+ project(':iceberg-mr-hive2') {
Review comment:
nit: we can possibly make this a var which can be set when we check
`hive3Enabled` to either `:iceberg-mr-hive2` or `:iceberg-mr-hive3` . This
would the remove if/else branches, here and at line 441 also
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
