rdblue commented on a change in pull request #1481:
URL: https://github.com/apache/iceberg/pull/1481#discussion_r493968652
##########
File path: mr/src/main/java/org/apache/iceberg/mr/Catalogs.java
##########
@@ -44,23 +61,31 @@
private static final String NAME = "name";
private static final String LOCATION = "location";
+ private static final Set<String> PROPERTIES_TO_REMOVE = Stream
+ .of(InputFormatConfig.TABLE_SCHEMA, InputFormatConfig.PARTITION_SPEC,
LOCATION, NAME)
+ .collect(Collectors.toCollection(HashSet::new));
Review comment:
Normally, we would use `ImmutableSet.of(...)`. That's simpler and
creates a set that can't be modified.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
