lidavidm commented on code in PR #86:
URL: https://github.com/apache/iceberg-cpp/pull/86#discussion_r2055658280
##########
src/iceberg/util/formatter.h:
##########
@@ -40,3 +43,102 @@ struct std::formatter<Derived> :
std::formatter<std::string_view> {
return std::formatter<string_view>::format(obj.ToString(), ctx);
}
};
+
+/// \brief std::formatter specialization for std::vector
+template <typename T>
+struct std::formatter<std::vector<T>> : std::formatter<std::string_view> {
Review Comment:
SGTM.
It might be good to expose formatter specializations on our own types, just
so long as they're separate from the specializations for std types
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
