zeroshade commented on code in PR #400:
URL: https://github.com/apache/iceberg-go/pull/400#discussion_r2060481292
##########
catalog/glue/glue_test.go:
##########
@@ -791,7 +791,7 @@ func TestGlueListTablesIntegration(t *testing.T) {
}
assert.NoError(lastErr)
- assert.Equal([]string{os.Getenv("TEST_DATABASE_NAME"),
os.Getenv("TEST_TABLE_NAME")}, tbls[1])
+ assert.Contains(tbls, []string{os.Getenv("TEST_DATABASE_NAME"),
os.Getenv("TEST_TABLE_NAME")})
Review Comment:
can we add a comment as to why we use "contains" rather than "equal". We
should at least be asserting the order somewhat, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
