Xuanwo commented on PR #1265:
URL: https://github.com/apache/iceberg-rust/pull/1265#issuecomment-2833296718
Some tests failed for:
```rust
----
catalog::tests::test_create_deeply_nested_namespace_throws_error_if_intermediate_namespace_doesnt_exist
stdout ----
thread
'catalog::tests::test_create_deeply_nested_namespace_throws_error_if_intermediate_namespace_doesnt_exist'
panicked at crates/catalog/memory/src/catalog.rs:688:9:
assertion `left == right` failed
left: "NamespaceNotFound => No such namespace: NamespaceIdent([\"a\",
\"b\"])"
right: "NotFound => No such namespace: NamespaceIdent([\"a\", \"b\"])"
----
catalog::tests::test_create_namespace_throws_error_if_namespace_already_exists
stdout ----
thread
'catalog::tests::test_create_namespace_throws_error_if_namespace_already_exists'
panicked at crates/catalog/memory/src/catalog.rs:594:9:
assertion `left == right` failed
left: "NamespaceAlreadyExists => Cannot create namespace
NamespaceIdent([\"a\"]). Namespace already exists."
right: "AlreadyExists => Cannot create namespace NamespaceIdent([\"a\"]).
Namespace already exists."
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
----
catalog::tests::test_create_nested_namespace_throws_error_if_top_level_namespace_doesnt_exist
stdout ----
thread
'catalog::tests::test_create_nested_namespace_throws_error_if_top_level_namespace_doesnt_exist'
panicked at crates/catalog/memory/src/catalog.rs:663:9:
assertion `left == right` failed
left: "NamespaceNotFound => No such namespace: NamespaceIdent([\"a\"])"
right: "NotFound => No such namespace: NamespaceIdent([\"a\"])"
----
catalog::tests::test_drop_namespace_throws_error_if_namespace_doesnt_exist
stdout ----
thread
'catalog::tests::test_drop_namespace_throws_error_if_namespace_doesnt_exist'
panicked at crates/catalog/memory/src/catalog.rs:933:9:
assertion `left == right` failed
left: "NamespaceNotFound => No such namespace: NamespaceIdent([\"abc\"])"
right: "NotFound => No such namespace: NamespaceIdent([\"abc\"])"
```
cc @liurenjie1024, I believe we can introduce snapshot testing to make it
easier to track those changes, like using https://github.com/mitsuhiko/insta
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
