nastra commented on code in PR #12881:
URL: https://github.com/apache/iceberg/pull/12881#discussion_r2072930543
##########
gcp/src/main/java/org/apache/iceberg/gcp/gcs/GCSFileIO.java:
##########
@@ -209,25 +180,65 @@ private void initMetrics(Map<String, String> props) {
}
}
+ private Cache<String, PrefixedStorage> storageCache() {
+ if (null == storageCache) {
+ synchronized (this) {
+ if (null == storageCache) {
+ this.storageCache =
+ Caffeine.newBuilder()
Review Comment:
yes, one reason was to make this serializable and the other reason was to
propagate the closure of the storage client, but I guess we can achieve the
same by using a simple HashMap
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
