amogh-jahagirdar commented on code in PR #12972:
URL: https://github.com/apache/iceberg/pull/12972#discussion_r2074294949
##########
aws/src/integration/java/org/apache/iceberg/aws/s3/TestS3MultipartUpload.java:
##########
@@ -63,7 +64,13 @@ public static void beforeClass() {
properties = new S3FileIOProperties();
properties.setMultiPartSize(S3FileIOProperties.MULTIPART_SIZE_MIN);
properties.setChecksumEnabled(true);
- io = new S3FileIO(() -> s3, properties);
+ io = new S3FileIO(() -> s3);
+ io.initialize(
+ ImmutableMap.of(
+ S3FileIOProperties.MULTIPART_SIZE,
+ Integer.toString(S3FileIOProperties.MULTIPART_SIZE_MIN),
+ S3FileIOProperties.CHECKSUM_ENABLED,
+ "true"));
Review Comment:
Yeah I actually think the explicit "true" is better in this case tbh
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
