nastra commented on code in PR #13021:
URL: https://github.com/apache/iceberg/pull/13021#discussion_r2084708481
##########
flink/v2.0/flink/src/test/java/org/apache/iceberg/flink/source/TestIcebergSourceFailover.java:
##########
@@ -314,20 +313,6 @@ private void
createBoundedStreams(StreamExecutionEnvironment env, int failAfter)
// test utilities copied from Flink's FileSourceTextLinesITCase
// ------------------------------------------------------------------------
- private static void runTestWithNewMiniCluster(ThrowingConsumer<MiniCluster,
Exception> testMethod)
- throws Exception {
- MiniClusterWithClientResource miniCluster = null;
- try {
- miniCluster = new
MiniClusterWithClientResource(MINI_CLUSTER_RESOURCE_CONFIG);
Review Comment:
the issue is that the tests are timing out now without the config:
```
TestIcebergSourceFailover > testBoundedWithJobManagerFailover(MiniCluster)
FAILED
java.util.concurrent.TimeoutException:
testBoundedWithJobManagerFailover(org.apache.flink.runtime.minicluster.MiniCluster)
timed out after 120 seconds
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
TestIcebergSourceFailover > testBoundedWithTaskManagerFailover(MiniCluster)
FAILED
java.util.concurrent.TimeoutException:
testBoundedWithTaskManagerFailover(org.apache.flink.runtime.minicluster.MiniCluster)
timed out after 120 seconds
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
TestIcebergSourceFailoverWithWatermarkExtractor >
testBoundedWithJobManagerFailover(MiniCluster) FAILED
java.util.concurrent.TimeoutException:
testBoundedWithJobManagerFailover(org.apache.flink.runtime.minicluster.MiniCluster)
timed out after 120 seconds
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
TestIcebergSourceFailoverWithWatermarkExtractor >
testBoundedWithTaskManagerFailover(MiniCluster) FAILED
java.util.concurrent.TimeoutException:
testBoundedWithTaskManagerFailover(org.apache.flink.runtime.minicluster.MiniCluster)
timed out after 120 seconds
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
at java.base/java.util.ArrayList.forEach(ArrayList.java:1541)
[IOManagerAsync shutdown hook] INFO
org.apache.flink.runtime.io.disk.FileChannelManagerImpl - FileChannelManager
removed spill file directory /tmp/flink-io-64570821-dedb-45dd-8180-5da4be9b26ac
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
