zhangjun0x01 commented on issue #1437:
URL: https://github.com/apache/iceberg/issues/1437#issuecomment-699573375


   > I think it's a good idea to load `hive-site.xml` and respect its defaults. 
But for cases like a missing warehouse directory for a catalog, I think we 
should prefer configuring the warehouse on the catalog itself. It doesn't make 
sense for multiple catalogs to use the same `hive-site.xml` setting for 
warehouse directory.
   
   
   My idea is that the configuration of hive is obtained by loading 
hive-site.xml, but we also support users to configure warehouse. 
   
   - If the user configures warehouse, the value in hive-site.xml will be 
overwritten, just like when we create hive table the location can be specified. 
   - the user does not configure a warehouse, the default value in 
hive-site.xml is used. 
   - the user does not specify a warehouse and hive-site.xml is not configured 
in hive-site.xml, an exception will be thrown.
   
   What do you think for this? @rdblue 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to