kbendick commented on a change in pull request #1491:
URL: https://github.com/apache/iceberg/pull/1491#discussion_r495519829
##########
File path: core/src/main/java/org/apache/iceberg/avro/PruneColumns.java
##########
@@ -39,6 +39,7 @@
private final NameMapping nameMapping;
PruneColumns(Set<Integer> selectedIds, NameMapping nameMapping) {
+ Preconditions.checkNotNull(selectedIds, "Selected field ids cannot be
null");
Review comment:
I will also check if `nameMapping` needs a precondition null check.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
