RussellSpitzer commented on code in PR #13060:
URL: https://github.com/apache/iceberg/pull/13060#discussion_r2093292196
##########
core/src/main/java/org/apache/iceberg/TableMetadata.java:
##########
@@ -1907,5 +1916,23 @@ private boolean isAddedSnapshot(long snapshotId) {
private <U extends MetadataUpdate> Stream<U> changes(Class<U> updateClass)
{
return
changes.stream().filter(updateClass::isInstance).map(updateClass::cast);
}
+
+ /**
+ * Parquet is currently the only format compatible with v3. Other formats
are missing support
+ * for features like default values, type support, etc. which makes
creating or updating to v3
+ * tables unsafe. Supported formats should be expanded as support is
implemented.
+ */
+ private static void validateFileFormatCompatibility(
Review Comment:
:nit: Could be validateDataFileFormatCompatibility
Just to remove ambiguity
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
