stevenzwu commented on code in PR #13081:
URL: https://github.com/apache/iceberg/pull/13081#discussion_r2093599959
##########
api/src/test/java/org/apache/iceberg/TestIcebergBuild.java:
##########
@@ -37,6 +41,34 @@ public void testFullVersion() {
+ ")");
}
+ @Test
+ public void testVersionNotUnspecified() {
+ assertThat(IcebergBuild.version()).isNotEqualTo("unspecified");
+ }
+
+ @Test
+ public void testVersionMatchesSystemProperty() {
+ assumeThat(System.getProperty("project.version")).isNotNull();
+ assertThat(IcebergBuild.version())
+ .isEqualTo(System.getProperty("project.version"))
+ .as("IcebergBuild.version() should match system property
project.version");
Review Comment:
no need to change this cherrypick.
maybe we can just fix the main branch later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
