simonsssu commented on a change in pull request #1515:
URL: https://github.com/apache/iceberg/pull/1515#discussion_r495533023
##########
File path: flink/src/main/java/org/apache/iceberg/flink/sink/FlinkSink.java
##########
@@ -153,6 +158,11 @@ public Builder hadoopConf(Configuration newHadoopConf) {
return this;
}
+ public Builder flinkConf(org.apache.flink.configuration.Configuration
config) {
+ this.flinkConf = config != null ? config : new
org.apache.flink.configuration.Configuration();
+ return this;
+ }
Review comment:
Thanks Kyle, I agree with you, we should not use a null to call a
builder, someone who want to use this may always know to pass a defined
configuration.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
