liukun4515 commented on a change in pull request #1516:
URL: https://github.com/apache/iceberg/pull/1516#discussion_r495535699
##########
File path:
flink/src/main/java/org/apache/iceberg/flink/source/RowDataIterator.java
##########
@@ -106,11 +116,12 @@
return builder.build();
}
- private CloseableIterable<RowData> newParquetIterable(FileScanTask task,
Map<Integer, ?> idToConstant) {
+ private CloseableIterable<RowData> newParquetIterable(FileScanTask task,
Schema schema,
+ Map<Integer, ?>
idToConstant) {
Parquet.ReadBuilder builder = Parquet.read(getInputFile(task))
.split(task.start(), task.length())
- .project(projectedSchema)
- .createReaderFunc(fileSchema ->
FlinkParquetReaders.buildReader(projectedSchema, fileSchema, idToConstant))
+ .project(schema)
Review comment:
I think the `projectedschema` makes more sense than schema.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
