stevenzwu commented on code in PR #12774: URL: https://github.com/apache/iceberg/pull/12774#discussion_r2096136844
########## core/src/main/java/org/apache/iceberg/io/AppenderBuilder.java: ########## @@ -0,0 +1,109 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ +package org.apache.iceberg.io; + +import java.io.IOException; +import java.nio.ByteBuffer; +import java.util.Map; +import org.apache.iceberg.MetricsConfig; +import org.apache.iceberg.Schema; + +/** + * Interface which is implemented by the data file format implementations. The {@link ObjectModel} + * provides the {@link AppenderBuilder} for the given parameters: + * + * <ul> + * <li>file format + * <li>engine specific object model + * <li>{@link ObjectModel.WriteMode} + * </ul> + * + * The {@link AppenderBuilder} is used to write data to the target files. + * + * @param <B> type returned by builder API to allow chained calls + * @param <E> the engine specific schema of the input data + */ +public interface AppenderBuilder<B extends AppenderBuilder<B, E>, E> { Review Comment: since we are doing a major refactoring of writer interface, I am wondering if there is an appetite for revisiting the current writer class organization. I just found it weird to have the opposite side of `ReadBuilder` to be `AppenderBuilder` and not `WriteBuilder`. > FileAppender should be named as `FileWriter` for write data to a specific file format. And the current `FileWriter` should be called `ContentFileWriter` or `ContentWriter`, because it handles `ContentFile` which is a data, position delete, or equality delete file. But I guess we might be too late for that. I don't know if we can involve this in a compatible without changing the package name of `FileWriter`. But if it is achievable, that would be really nice. > If I remember correctly @danielcweeks had a comment suggesting to move as much as possible to data. I agree with him, as I feel that the core module starts to get bloated, and everything is pushed there. The data module already contains classes for accessing data independently of the actual File Format. I think the ObjectModelRegistry has the same function. Agree that core module is bloated. If there is a good and compatible way to evolve the structure, I would be happy to see it. I know it is a big effort that shouldn't be taken lightly. @aokolnychyi @danielcweeks @RussellSpitzer @rdblue any comment? maybe this can be brought up in the next community sync? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
