mehtaashish23 commented on a change in pull request #1514:
URL: https://github.com/apache/iceberg/pull/1514#discussion_r496259864
##########
File path:
spark/src/main/java/org/apache/iceberg/spark/source/BaseDataReader.java
##########
@@ -58,9 +60,12 @@
BaseDataReader(CombinedScanTask task, FileIO io, EncryptionManager
encryptionManager) {
this.tasks = task.files().iterator();
- Stream<EncryptedInputFile> encrypted = task.files().stream()
- .flatMap(fileScanTask -> Stream.concat(Stream.of(fileScanTask.file()),
fileScanTask.deletes().stream()))
- .map(file ->
EncryptedFiles.encryptedInput(io.newInputFile(file.path().toString()),
file.keyMetadata()));
+ Map<CharSequence, DeleteFile> uniqueDeleteFileMap = Maps.newHashMap();
Review comment:
I actually started with deduping both DataFile and DeleteFile, but
thought of keeping it just for DeleteFile, to not touch other workflows. will
follow your recommendation. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
