rdblue commented on a change in pull request #1478:
URL: https://github.com/apache/iceberg/pull/1478#discussion_r496314459
##########
File path: build.gradle
##########
@@ -468,6 +468,79 @@ project(':iceberg-mr') {
}
}
+if (jdkVersion == '8') {
+ project(':iceberg-mr-hive3') {
+
+ // run the tests in iceberg-mr with Hive3 dependencies
+ sourceSets {
+ test {
+ java.srcDirs = ['../mr/src/test/java', 'src/test/java']
+ resources.srcDirs = ['../mr/src/test/resources', 'src/test/resources']
+ }
+ }
+
+ // exclude these Hive2-specific tests from iceberg-mr
+ test {
+ exclude '**/TestIcebergDateObjectInspector.class'
+ exclude '**/TestIcebergTimestampObjectInspector.class'
+ }
+
+ configurations.all {
+ resolutionStrategy.eachDependency { dep ->
+ if (dep.requested.group == 'org.apache.hive' && dep.requested.name !=
'hive-storage-api') {
+ dep.useVersion '3.1.2'
+ } else if (dep.requested.group == 'org.apache.hadoop') {
+ dep.useVersion '3.1.0'
+ }
+ }
+ }
Review comment:
Is this block needed? I think we should be able to explicitly set
dependency versions in the `dependencies` block, like this:
```
compileOnly("org.apache.hive:hive-exec:3.1.2:core") {
...
}
compileOnly("org.apache.hadoop:hadoop-client:3.1.0") {
...
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
