rdblue commented on a change in pull request #1477:
URL: https://github.com/apache/iceberg/pull/1477#discussion_r496319732
##########
File path: core/src/main/java/org/apache/iceberg/io/OutputFileFactory.java
##########
@@ -57,20 +57,26 @@ private String generateFilename() {
String.format("%05d-%d-%s-%05d", partitionId, taskId, uuid,
fileCount.incrementAndGet()));
}
+ /**
+ * Generates EncryptedOutputFile with relative path under iceberg table
location.
+ */
+ public EncryptedOutputFile newOutputFile(String relativePath) {
Review comment:
This class needs to create full paths. It should not create an output
file for a relative path like this. That's why the location provider is used in
the other cases.
Also, as I noted below, metadata files should not use the encryption manager
and should also use `TableOperations.metadataFileLocation` to create a full
path from a manifest file name. So I don't think we will need to add a method
here.
That is, unless you wanted to rename this to `newMetadataOutputFile`, call
`ops.metadataFileLocation` to create the full path, and bypass the encryption
manager.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
