manuzhang commented on code in PR #13208:
URL: https://github.com/apache/iceberg/pull/13208#discussion_r2125245986
##########
spark/v3.4/spark/src/test/java/org/apache/iceberg/spark/actions/TestRewriteDataFilesAction.java:
##########
@@ -1341,7 +1341,8 @@ public void
testParallelPartialProgressWithMaxFailedCommitsLargerThanTotalFileGr
// Since we can have at most one commit per file group and there
are only 10 file
// groups, actual number of commits is 10
.option(RewriteDataFiles.PARTIAL_PROGRESS_MAX_COMMITS, "20")
- .option(RewriteDataFiles.PARTIAL_PROGRESS_MAX_FAILED_COMMITS, "0");
+ // Setting max-failed-commits to 1 to tolerate random commit
failure
+ .option(RewriteDataFiles.PARTIAL_PROGRESS_MAX_FAILED_COMMITS, "1");
Review Comment:
Not sure as there are no logs from GitHub CI and I can't reproduce it
locally. On the other hand, this UT checks whether the number of failed commits
is calculated correctly when total group count(10) is smaller than
`partial-progress.max-commits`(20). Hence, I think it's ok to tolerate commit
failure no matter why it happens.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
