rdblue commented on a change in pull request #1478:
URL: https://github.com/apache/iceberg/pull/1478#discussion_r496949231
##########
File path:
mr/src/main/java/org/apache/iceberg/mr/hive/serde/objectinspector/IcebergObjectInspector.java
##########
@@ -72,7 +85,7 @@ public ObjectInspector primitive(Type.PrimitiveType
primitiveType) {
primitiveTypeInfo = TypeInfoFactory.booleanTypeInfo;
break;
case DATE:
- return IcebergDateObjectInspector.get();
+ return DATE_INSPECTOR.invoke();
Review comment:
Minor: we could invoke this just once and store it in a `private static
final` field. Same with timestamps. We could store both in fields and choose
one using `adjustToUtc`. Not a big deal to always call the reflection method
here, though.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
