ericsun2 commented on issue #417: URL: https://github.com/apache/iceberg/issues/417#issuecomment-700913708
"type promotion" is only 50% of the case/problem. For a given numeric value, it can represent various precision and hence different rollup/truncate logic. If we limit the API to only take TIMESTAMP or EPOCH_MILLIS as input, then "type promotion" will be probably OK (except for time_zone override at partition spec level: do we only honor `spark.sql.session.timeZone` or `user.timezone`?). But users will have to do the math to convert epoch second/minute/hour offset value to millisecond first. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
