agchang commented on code in PR #454:
URL: https://github.com/apache/iceberg-go/pull/454#discussion_r2130031753
##########
io/gcs.go:
##########
@@ -55,7 +55,16 @@ func ParseGCSConfig(props map[string]string)
*gcsblob.Options {
// Construct a GCS bucket from a URL
func createGCSBucket(ctx context.Context, parsed *url.URL, props
map[string]string) (*blob.Bucket, error) {
gcscfg := ParseGCSConfig(props)
- client := gcp.NewAnonymousHTTPClient(gcp.DefaultTransport())
+ creds, err := gcp.DefaultCredentials(ctx) // or use
service-account JSON
Review Comment:
I updated the code to still fallback to the old method if creds aren't
found, so it won't break existing use cases.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
