geruh commented on code in PR #2066: URL: https://github.com/apache/iceberg-python/pull/2066#discussion_r2131646939
########## mkdocs/docs/configuration.md: ########## @@ -346,6 +346,7 @@ catalog: | rest.signing-name | execute-api | The service signing name to use when SigV4 signing a request | | oauth2-server-uri | <https://auth-service/cc> | Authentication URL to use for client credentials authentication (default: uri + 'v1/oauth/tokens') | | snapshot-loading-mode | refs | The snapshots to return in the body of the metadata. Setting the value to `all` would return the full set of snapshots currently valid for the table. Setting the value to `refs` would load all snapshots referenced by branches or tags. | +| warehouse | myCatalog | For some catalog implementations like Databricks Unity, the warehouse is mandatory to identify which top level container (e.g. catalog, metastore...) is accessed. Namespaces are within this container. | Review Comment: This configuration is used across all catalog's, so wdyt about saying something closer to the root directory in storage where new Iceberg tables are created, also it may be worth mentioning that some REST clients may override this path via the `getConfig` api. https://github.com/apache/iceberg/blob/main/open-api/rest-catalog-open-api.yaml#L97 We should also have a storage path be the example. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
