wypoon commented on pull request #1508: URL: https://github.com/apache/iceberg/pull/1508#issuecomment-701030861
Thanks everyone for your interest in this work! @rdblue, I think it makes sense to get a version of this PR in first, and separately, do the work to associate a schema with each snapshot, while aligning this PR with the other work as much as possible. To check that we're on the same page, your original suggestion was to add a list `schemas` to table metadata, add a `schema-id` to each schema, and add a `schema-id` to each snapshot. When this is done, `Snapshot` should have a `schema()` method. IIUC, the schema still has to be read from the table metadata file, referenced using the `schema-id` from the snapshot. Thus an implementation of `Snapshot` would need a reference to the table metadata, correct? Right now, to get the schema, I need to start from the table metadata file. There is currently no obvious way to get from snapshot to table metadata. I'd need to change the implementation of `Snapshot` to have a reference to the current metadata. Does that make sense to you? Or am I missing something? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org For additional commands, e-mail: issues-h...@iceberg.apache.org
