chenjunjiedada commented on a change in pull request #1497:
URL: https://github.com/apache/iceberg/pull/1497#discussion_r497138463
##########
File path: data/src/test/java/org/apache/iceberg/data/DeletesReadTest.java
##########
@@ -80,21 +95,37 @@ public void testEqualityDeletes() throws IOException {
);
DeleteFile eqDeletes = FileHelpers.writeDeleteFile(
- table, Files.localOutput(temp.newFile()), Row.of(0), dataDeletes,
deleteRowSchema);
+ testTable, Files.localOutput(temp.newFile()), Row.of(0), dataDeletes,
deleteRowSchema);
- table.newRowDelta()
+ testTable.newRowDelta()
.addDeletes(eqDeletes)
.commit();
StructLikeSet expected = rowSetWithoutIds(29, 89, 122);
- StructLikeSet actual = rowSet(table);
+ StructLikeSet actual = rowSet(testTable);
Assert.assertEquals("Table should contain expected rows", expected,
actual);
}
+ protected void generateTestData() throws IOException {
Review comment:
Okay, make sense to me. Moved to `@Before`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
