marton-bod opened a new issue #1534:
URL: https://github.com/apache/iceberg/issues/1534


   `TestCatalogs.testCreateDropTableToLocation` creates a temporary folder in 
the wrong location and fails to clean it up in the end. That's because 
`tmp.toString()` is used in a couple of places:
   
https://github.com/apache/iceberg/blob/master/mr/src/test/java/org/apache/iceberg/mr/TestCatalogs.java#L110
   
https://github.com/apache/iceberg/blob/master/mr/src/test/java/org/apache/iceberg/mr/TestCatalogs.java#L130
 
   
   `tmp.toString()` gives back the default string representation of 
`TemporaryFolder`, e.g. `org.junit.rules.TemporaryFolder@6688b3d0`. When adding 
the `location` property to the properties using this method, we end up creating 
a directory called `org.junit.rules.TemporaryFolder@6688b3d0` inadvertently. 
Instead of `tmp.toString()`, we should use `tmp.getRoot()` to resolve this 
issue.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to