aokolnychyi commented on a change in pull request #1530:
URL: https://github.com/apache/iceberg/pull/1530#discussion_r497769381
##########
File path: core/src/test/java/org/apache/iceberg/hadoop/TestHadoopCatalog.java
##########
@@ -525,6 +525,34 @@ public void testVersionHintFileMissingMetadata() throws
Exception {
() -> TABLES.load(tableLocation));
}
+ @Test
+ public void testTableEquality() throws Exception {
Review comment:
The main motivation to implement `equals` and `hashCode` was to refresh
the cache in Spark. Therefore, I did not consider anything except the
identifier so that if a table property was modified, we would still invalidate
the cache as both entries point to the same table.
After thinking about this more, modifying `equals` and `hashCode` in
`BaseTable` may not be the best idea. Instead, we can simply compare
`icebergTable.toString()` in `SparkTable` and limit this equality on table
identifiers only to Spark.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
