RussellSpitzer commented on code in PR #13191:
URL: https://github.com/apache/iceberg/pull/13191#discussion_r2152469836
##########
.palantir/revapi.yml:
##########
@@ -1285,6 +1285,12 @@ acceptedBreaks:
- code: "java.field.removedWithConstant"
old: "field org.apache.iceberg.TableProperties.ROW_LINEAGE"
justification: "Removing deprecations for 1.10.0"
+ - code: "java.method.abstractMethodAdded"
+ new: "method <T extends org.apache.iceberg.rest.RESTResponse> T
org.apache.iceberg.rest.BaseHTTPClient::execute(org.apache.iceberg.rest.HTTPRequest,\
+ \ java.lang.Class<T>,
java.util.function.Consumer<org.apache.iceberg.rest.responses.ErrorResponse>,\
+ \ java.util.function.Consumer<java.util.Map<java.lang.String,
java.lang.String>>,\
+ \ org.apache.iceberg.rest.ParserContext)"
+ justification: "Add context aware parsing"
Review Comment:
nit: The Justification here is that no one can depend on this api correct?
It's solely owned by the client and no one else can extend or use it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
