rdblue commented on a change in pull request #1532:
URL: https://github.com/apache/iceberg/pull/1532#discussion_r497779995
##########
File path: mr/src/main/java/org/apache/iceberg/mr/mapreduce/IcebergSplit.java
##########
@@ -79,12 +85,36 @@ public void write(DataOutput out) throws IOException {
byte[] data = SerializationUtil.serializeToBytes(this.task);
out.writeInt(data.length);
out.write(data);
+
+ byte[] ioData = SerializationUtil.serializeToBytes(io);
+ out.writeInt(ioData.length);
+ out.write(ioData);
+
+ byte[] encryptionManagerData =
SerializationUtil.serializeToBytes(encryptionManager);
+ out.writeInt(encryptionManagerData.length);
+ out.write(encryptionManagerData);
}
@Override
public void readFields(DataInput in) throws IOException {
byte[] data = new byte[in.readInt()];
in.readFully(data);
this.task = SerializationUtil.deserializeFromBytes(data);
+
+ byte[] ioData = new byte[in.readInt()];
+ in.readFully(ioData);
+ this.io = SerializationUtil.deserializeFromBytes(ioData);
+
+ byte[] encryptionManagerData = new byte[in.readInt()];
+ in.readFully(encryptionManagerData);
+ this.encryptionManager =
SerializationUtil.deserializeFromBytes(encryptionManagerData);
+ }
+
+ public FileIO fileIO() {
Review comment:
This is named `io` in `Table`, so I don't think a longer name is needed
here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
