pvary commented on code in PR #13340:
URL: https://github.com/apache/iceberg/pull/13340#discussion_r2156705330
##########
flink/v2.0/flink/src/main/java/org/apache/iceberg/flink/sink/dynamic/DynamicRecordProcessor.java:
##########
@@ -142,10 +151,18 @@ private void emit(
Schema schema,
CompareSchemasVisitor.Result result,
PartitionSpec spec) {
- RowData rowData =
- result == CompareSchemasVisitor.Result.SAME
- ? data.rowData()
- : RowDataEvolver.convert(data.rowData(), data.schema(), schema);
+ RowData rowData;
+ if (result == CompareSchemasVisitor.Result.SAME) {
+ rowData = data.rowData();
+ } else {
+ RowDataConverter rowDataConverter =
+ converterCache.get(
+ data.schema(),
+ dataSchema ->
+ new RowDataConverter(
+ FlinkSchemaUtil.convert(dataSchema),
FlinkSchemaUtil.convert(schema)));
+ rowData = rowDataConverter.convert(data.rowData());
+ }
Review Comment:
nit: newline
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
