nastra commented on code in PR #13333:
URL: https://github.com/apache/iceberg/pull/13333#discussion_r2160890283


##########
format/spec.md:
##########
@@ -617,17 +617,40 @@ A manifest file must store the partition spec and other 
metadata as properties i
 | _optional_ | _required_ | `format-version`    | Table format version number 
of the manifest as a string                      |
 |            | _required_ | `content`           | Type of content files 
tracked by the manifest: "data" or "deletes"           |
 
-The schema of a manifest file is a struct called `manifest_entry` with the 
following fields:
+The schema of a manifest file is defined by the `manifest_entry` struct, 
described in the following section.
 
-| v1         | v2         | Field id, name                | Type               
                                       | Description |
-| ---------- | ---------- 
|-------------------------------|-----------------------------------------------------------|-------------|
-| _required_ | _required_ | **`0  status`**               | `int` with 
meaning: `0: EXISTING` `1: ADDED` `2: DELETED` | Used to track additions and 
deletions. Deletes are informational only and not used in scans. |
-| _required_ | _optional_ | **`1  snapshot_id`**          | `long`             
                                       | Snapshot id where the file was added, 
or deleted if status is 2. Inherited when null. |
-|            | _optional_ | **`3  sequence_number`**      | `long`             
                                       | Data sequence number of the file. 
Inherited when null and status is 1 (added). |
-|            | _optional_ | **`4  file_sequence_number`** | `long`             
                                       | File sequence number indicating when 
the file was added. Inherited when null and status is 1 (added). |
-| _required_ | _required_ | **`2  data_file`**            | `data_file` 
`struct` (see below)                          | File path, partition tuple, 
metrics, ... |
 
-`data_file` is a struct with the following fields:
+#### Manifest Entry Fields

Review Comment:
   can you please add the heading without actually modifying the table since 
that causes unnecessary diffs during review



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org

Reply via email to