liurenjie1024 commented on code in PR #1462:
URL: https://github.com/apache/iceberg-rust/pull/1462#discussion_r2163564473
##########
crates/iceberg/src/expr/visitors/manifest_evaluator.rs:
##########
@@ -33,7 +33,10 @@ pub(crate) struct ManifestEvaluator {
}
impl ManifestEvaluator {
- pub(crate) fn new(partition_filter: BoundPredicate) -> Self {
+ /// `ManifestEvaluator` is not support to evaluate predicate with `not`
operator.
+ /// This function requires that caller pass the predicate has been
rewritten. Otherwise,
+ /// it will return unexpected error when evaluating the predicate.
+ pub(crate) fn new_without_rewrite_not(partition_filter: BoundPredicate) ->
Self {
Review Comment:
Instead of renaming constructor, how about add a new builder function like
following:
```rust
pub(crate) fn with_rewrite_not(self, rewrite: bool) {
...
}
```
Also we should add some tests to cover rewriting not
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
