pvary commented on code in PR #13425:
URL: https://github.com/apache/iceberg/pull/13425#discussion_r2174552659
##########
core/src/main/java/org/apache/iceberg/PartitionStatsHandler.java:
##########
@@ -115,6 +120,53 @@ public static Schema schema(StructType
unifiedPartitionType) {
LAST_UPDATED_SNAPSHOT_ID);
}
+ /**
+ * Generates the partition stats file schema based on a combined partition
type which considers
+ * all specs in a table. (For format version 3 and above)
+ *
+ * @param unifiedPartitionType unified partition schema type. Could be
calculated by {@link
+ * Partitioning#partitionType(Table)}.
+ * @return a schema that corresponds to the provided unified partition type.
+ */
+ public static Schema schemaV3Plus(StructType unifiedPartitionType) {
Review Comment:
Could this be `public static Schema schema(StructType unifiedPartitionType,
FormatVersion version) {`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
