blinkseb commented on code in PR #2153:
URL: https://github.com/apache/iceberg-python/pull/2153#discussion_r2174600377
##########
pyiceberg/cli/console.py:
##########
@@ -361,9 +361,9 @@ def table(ctx: Context, identifier: str, property_name:
str, property_value: str
catalog, output = _catalog_and_output(ctx)
identifier_tuple = Catalog.identifier_to_tuple(identifier)
- _ = catalog.load_table(identifier_tuple)
- output.text(f"Setting {property_name}={property_value} on {identifier}")
- raise NotImplementedError("Writing is WIP")
+ table = catalog.load_table(identifier_tuple)
+ table.transaction().set_properties({property_name:
property_value}).commit_transaction()
Review Comment:
Looks cleaner indeed, I'll update the PR, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
