nastra commented on code in PR #12563:
URL: https://github.com/apache/iceberg/pull/12563#discussion_r2175113613
##########
core/src/main/java/org/apache/iceberg/rest/auth/RefreshingAuthManager.java:
##########
@@ -18,73 +18,27 @@
*/
package org.apache.iceberg.rest.auth;
-import java.util.List;
-import java.util.concurrent.Future;
import java.util.concurrent.ScheduledExecutorService;
-import java.util.concurrent.TimeUnit;
import javax.annotation.Nullable;
import org.apache.iceberg.util.ThreadPools;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
/**
- * An {@link AuthManager} that provides machinery for refreshing
authentication data asynchronously,
- * using a background thread pool.
+ * @deprecated since 1.9.0, will be removed in 1.10.0; use {@link
ThreadPools#getAuthRefreshPool()}.
Review Comment:
version info needs to be updated here, since the deprecation applies with
1.10.0 and we can only remove with 1.11.0
##########
core/src/main/java/org/apache/iceberg/rest/auth/RefreshingAuthManager.java:
##########
@@ -18,73 +18,27 @@
*/
package org.apache.iceberg.rest.auth;
-import java.util.List;
-import java.util.concurrent.Future;
import java.util.concurrent.ScheduledExecutorService;
-import java.util.concurrent.TimeUnit;
import javax.annotation.Nullable;
import org.apache.iceberg.util.ThreadPools;
-import org.slf4j.Logger;
-import org.slf4j.LoggerFactory;
/**
- * An {@link AuthManager} that provides machinery for refreshing
authentication data asynchronously,
- * using a background thread pool.
+ * @deprecated since 1.9.0, will be removed in 1.10.0; use {@link
ThreadPools#getAuthRefreshPool()}.
*/
+@Deprecated
Review Comment:
it's not clear to me why we're deprecating the entire class here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
