zhjwpku commented on PR #134: URL: https://github.com/apache/iceberg-cpp/pull/134#issuecomment-3019520789
Before I touch more code, I'd like to hear your thoughts on these factory functions for primitive types. For decimal and fixed types, return a newly created shared_ptr, while for other types, return a singleton instance. @wgtmac @lidavidm @gty404 @mapleFU -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
