mapleFU commented on code in PR #133:
URL: https://github.com/apache/iceberg-cpp/pull/133#discussion_r2175372250
##########
src/iceberg/file_reader.h:
##########
@@ -130,12 +76,12 @@ struct ICEBERG_EXPORT ReaderOptions {
std::optional<Split> split;
/// \brief The batch size to read. Only applies to implementations that
support
/// batching.
- int64_t batch_size;
+ int64_t batch_size = 4096;
Review Comment:
Add to a default config?
##########
src/iceberg/file_reader.h:
##########
@@ -50,66 +50,12 @@ class ICEBERG_EXPORT Reader {
/// \brief Read next data from file.
///
- /// \return std::monostate if the reader has no more data, otherwise
`ArrowArray` or
- /// `StructLike` depending on the data layout by the reader implementation.
- using Data =
- std::variant<std::monostate, ArrowArray, std::reference_wrapper<const
StructLike>>;
+ /// \return std::monostate if the reader has no more data, otherwise
`ArrowArray`.
+ using Data = std::variant<std::monostate, ArrowArray>;
Review Comment:
can we shift to optional?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
