Fokko commented on code in PR #11868:
URL: https://github.com/apache/iceberg/pull/11868#discussion_r2175922779
##########
core/src/main/java/org/apache/iceberg/Partitioning.java:
##########
@@ -239,7 +239,8 @@ public static StructType groupingKeyType(Schema schema,
Collection<PartitionSpec
*/
public static StructType partitionType(Table table) {
Collection<PartitionSpec> specs = table.specs().values();
- return buildPartitionProjectionType("table partition", specs,
allFieldIds(specs));
+ return buildPartitionProjectionType(
Review Comment:
Thanks, that's an excellent suggestion 👍
##########
spark/v3.5/spark-extensions/src/test/java/org/apache/iceberg/spark/extensions/TestAlterTablePartitionFields.java:
##########
@@ -583,4 +587,44 @@ private void createTable(String schema, String spec) {
tableName, schema, spec, TableProperties.FORMAT_VERSION,
formatVersion);
}
}
+
+ private void runCreateAndDropPartitionField(
+ String column, String partitionType, List<Object[]> expected, String
predicate) {
+ sql("DROP TABLE IF EXISTS %s", tableName);
+ sql(
+ "CREATE TABLE %s (col_int INTEGER, col_ts TIMESTAMP_NTZ, col_long
BIGINT) USING ICEBERG TBLPROPERTIES ('format-version' = %d)",
+ tableName, formatVersion);
+ sql("INSERT INTO %s VALUES (1000, CAST('2024-03-01 19:25:00' as
TIMESTAMP), 2100)", tableName);
Review Comment:
I think this is the GitHub UI, it is relatively aligned in my editor:
<img width="1470" alt="image"
src="https://github.com/user-attachments/assets/bdf12403-d58a-4383-bf11-16f5e50ff1e4";
/>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@iceberg.apache.org
For additional commands, e-mail: issues-h...@iceberg.apache.org
