geruh commented on PR #13347: URL: https://github.com/apache/iceberg/pull/13347#issuecomment-3025106350
Thanks for this, @SanjayMarreddi! I was able to run and validate the tests successfully. However, I’m a little concerned with the current approach, unless I'm missing something. Right now it seems we are manually setting the config and running the tests, and that could result in potential gaps. Since this configuration introduces a dependency, it's different from the existing S3 related configs. To reduce the risk of missing bugs, I’d suggest either splitting the tests into two sets or adding some additional tests specifically for the analytic accelerator. Relying on the manual config setup during testing might cause issues to slip through and not be caught during releases. What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
