sungwy commented on code in PR #2154: URL: https://github.com/apache/iceberg-python/pull/2154#discussion_r2178788343
########## tests/conftest.py: ########## Review Comment: I second @jayceslesar 's suggestion to add some integration tests for testing the new `create_view` function on the REST Catalog. As for the confusion regarding the sparse list of tests within the specific test file @jayceslesar is referring to, I think that's because we added a separate test file that holds tests for methods that only the REST Catalog has support for, like `namespace_exists`. I think it would make sense for us to add `create_view` there and ensure that the view is accessible through `view_exists` as well as through a spark session that is referring to the same REST Catalog using the same uri. The `session_catalog` fixture refers to the rest catalog fixture defined in this `conftest.py` file https://github.com/apache/iceberg-python/blob/e054b77c3e56dcc9371c3b4da27f3550151f20db/tests/conftest.py#L2440-L2450 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
